querify getting fake doc items by mejrs · Pull Request #161200 · rust-lang/rust

mejrs · 2026-08-16T22:03:27Z

mejrs · 2026-08-16T22:37:18Z

querify getting fake doc items

rust-bors · 2026-08-16T23:38:49Z

☀️ Try build successful (CI)
Build commit: f21c600 (f21c6005f028eabfec72893ab56022b3891a81f0)
Base parent: 34baba5 (34baba5394fcbda4cba7b7c1964a6db421c77c91)

rust-timer · 2026-08-17T00:20:40Z

Finished benchmarking commit (f21c600): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.1%, 0.3%]	2
Improvements ✅ (primary)	-0.7%	[-2.6%, -0.1%]	27
Improvements ✅ (secondary)	-1.4%	[-2.6%, -0.3%]	52
All ❌✅ (primary)	-0.7%	[-2.6%, -0.1%]	27

Max RSS (memory usage)

Results (primary 0.3%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.7%, 1.9%]	4
Regressions ❌ (secondary)	1.7%	[0.7%, 2.5%]	4
Improvements ✅ (primary)	-1.1%	[-1.5%, -0.5%]	3
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	0.3%	[-1.5%, 1.9%]	7

Cycles

Results (primary 2.0%, secondary -6.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.5%	[-30.8%, -1.6%]	7
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 455.832s -> 457.539s (0.37%)
Artifact size: 399.69 MiB -> 399.63 MiB (-0.02%)

rustbot · 2026-08-17T11:17:31Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustbot · 2026-08-17T11:17:34Z

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 16 candidates

camelid · 2026-08-20T20:23:39Z

r? @camelid

mejrs · 2026-09-03T11:12:37Z

r? compiler

camelid · 2026-09-03T17:39:57Z

Oh sorry for the review delay but I was actually reviewing this yesterday. I'll post a finished review asap.

mejrs · 2026-09-03T19:58:23Z

Oh sorry, I kinda glanced over the manual assignment 😳

camelid

Looks good overall, just a couple of comments.

View changes since this review

camelid · 2026-09-08T20:25:50Z

+    let features = tcx.features().enabled_features();
+    if features.contains(&sym::rustc_attrs) || features.contains(&sym::rustdoc_internals) {
+        // Collect fake doc items in this crate.
+        for id in tcx.hir_root_module().item_ids {


It seems like this query now works for any item in the root, not just const items (like the old code) did. Is that intentional? We should probably restrict to just const _ items.

It is still an error to put the attribute on something else, this doesn't matter for correctness.

Is that intentional?

Yes, what this code now does is check whether the attribute is on the item. What the old code did is perform a check for whether we should check for whether the attribute is on the item.

rustbot · 2026-09-08T21:28:05Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

mejrs · 2026-09-08T22:03:01Z

@rustbot ready

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 16, 2026

Auto merge of #161200 - mejrs:fake_item_queries, r=<try>

f21c600

querify getting fake doc items

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 17, 2026

mejrs mentioned this pull request Aug 17, 2026

rustdoc: use anonymous constant for primitives/keywords/attribute docs #160288

Merged

mejrs marked this pull request as ready for review August 17, 2026 11:17

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2026

rustbot assigned dingxiangfei2009 Aug 17, 2026

mejrs force-pushed the fake_item_queries branch from 2956a4e to a46b0ca Compare August 17, 2026 11:32

rustbot assigned camelid and unassigned dingxiangfei2009 Aug 20, 2026

rustbot assigned ShoyuVanilla and unassigned camelid Sep 3, 2026

mejrs force-pushed the fake_item_queries branch from a46b0ca to 71584d5 Compare September 3, 2026 12:34

This comment has been minimized.

Sign in to view

camelid self-assigned this Sep 3, 2026

camelid unassigned ShoyuVanilla Sep 3, 2026

camelid reviewed Sep 8, 2026

View reviewed changes

camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026

querify getting fake doc items

72e0459

mejrs force-pushed the fake_item_queries branch from 71584d5 to 72e0459 Compare September 8, 2026 21:28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2026

Uh oh!

Uh oh!

Conversation

mejrs commented Aug 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mejrs commented Aug 16, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 16, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Aug 17, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rustbot commented Aug 17, 2026

Uh oh!

rustbot commented Aug 17, 2026

Uh oh!

camelid commented Aug 20, 2026

Uh oh!

mejrs commented Sep 3, 2026

Uh oh!

This comment has been minimized.

camelid commented Sep 3, 2026

Uh oh!

mejrs commented Sep 3, 2026

Uh oh!

camelid left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camelid Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

mejrs Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Sep 8, 2026

Uh oh!

mejrs commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mejrs commented Aug 16, 2026 •

edited by rustbot

Loading

camelid left a comment •

edited by rustbot

Loading